Skip to content

Fix manual_unwrap_or_default FP on ref binding #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fix manual_unwrap_or_default FP on ref binding #14731

merged 1 commit into from
May 5, 2025
+28 −1

Conversation

profetia
Copy link
Contributor

@profetia profetia commented May 3, 2025 •
edited by rustbot
Loading

Closes #14716

changelog: [manual_unwrap_or_default] fix FP on ref binding

@rustbot
Copy link
Collaborator

rustbot commented May 3, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 3, 2025
Jarcho
Jarcho approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue May 5, 2025
Merged via the queue into rust-lang:master with commit f62f269 May 5, 2025
11 of 13 checks passed
@profetia profetia deleted the issue14716 branch September 12, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manual_unwrap_or_default suggested when ref keyword is used
3 participants
@profetia @rustbot @Jarcho